-
Notifications
You must be signed in to change notification settings - Fork 15.4k
[lldb/ScriptInterpreter] Fix typo in AbstractMethodCheckerPayload (NFC) #170187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a typo in ScriptedPythonInterface and changes `AbstrackMethodCheckerPayload` to `AbstractMethodCheckerPayload`. Signed-off-by: Med Ismail Bennani <[email protected]>
Member
|
@llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) ChangesThis fixes a typo in ScriptedPythonInterface and changes Full diff: https://github.com/llvm/llvm-project/pull/170187.diff 1 Files Affected:
diff --git a/lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptedPythonInterface.h b/lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptedPythonInterface.h
index af88a69e34a13..cdda66abc562b 100644
--- a/lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptedPythonInterface.h
+++ b/lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptedPythonInterface.h
@@ -41,7 +41,7 @@ class ScriptedPythonInterface : virtual public ScriptedInterface {
eValid
};
- struct AbstrackMethodCheckerPayload {
+ struct AbstractMethodCheckerPayload {
struct InvalidArgumentCountPayload {
InvalidArgumentCountPayload(size_t required, size_t actual)
@@ -55,13 +55,13 @@ class ScriptedPythonInterface : virtual public ScriptedInterface {
std::variant<std::monostate, InvalidArgumentCountPayload> payload;
};
- llvm::Expected<std::map<llvm::StringLiteral, AbstrackMethodCheckerPayload>>
+ llvm::Expected<std::map<llvm::StringLiteral, AbstractMethodCheckerPayload>>
CheckAbstractMethodImplementation(
const python::PythonDictionary &class_dict) const {
using namespace python;
- std::map<llvm::StringLiteral, AbstrackMethodCheckerPayload> checker;
+ std::map<llvm::StringLiteral, AbstractMethodCheckerPayload> checker;
#define SET_CASE_AND_CONTINUE(method_name, case) \
{ \
checker[method_name] = {case, {}}; \
@@ -102,7 +102,7 @@ class ScriptedPythonInterface : virtual public ScriptedInterface {
} else {
checker[method_name] = {
AbstractMethodCheckerCases::eInvalidArgumentCount,
- AbstrackMethodCheckerPayload::InvalidArgumentCountPayload(
+ AbstractMethodCheckerPayload::InvalidArgumentCountPayload(
requirement.min_arg_count, arg_info.max_positional_args)};
}
}
@@ -291,7 +291,7 @@ class ScriptedPythonInterface : virtual public ScriptedInterface {
case AbstractMethodCheckerCases::eInvalidArgumentCount: {
auto &payload_variant = method_checker.second.payload;
if (!std::holds_alternative<
- AbstrackMethodCheckerPayload::InvalidArgumentCountPayload>(
+ AbstractMethodCheckerPayload::InvalidArgumentCountPayload>(
payload_variant)) {
abstract_method_errors = llvm::joinErrors(
std::move(abstract_method_errors),
@@ -300,7 +300,7 @@ class ScriptedPythonInterface : virtual public ScriptedInterface {
obj_class_name.GetString(), method_checker.first)));
} else {
auto payload = std::get<
- AbstrackMethodCheckerPayload::InvalidArgumentCountPayload>(
+ AbstractMethodCheckerPayload::InvalidArgumentCountPayload>(
payload_variant);
abstract_method_errors = llvm::joinErrors(
std::move(abstract_method_errors),
|
bulbazord
approved these changes
Dec 1, 2025
kcloudy0717
pushed a commit
to kcloudy0717/llvm-project
that referenced
this pull request
Dec 4, 2025
…C) (llvm#170187) This fixes a typo in ScriptedPythonInterface and changes `AbstrackMethodCheckerPayload` to `AbstractMethodCheckerPayload`. Signed-off-by: Med Ismail Bennani <[email protected]>
medismailben
added a commit
to medismailben/llvm-project
that referenced
this pull request
Dec 6, 2025
…C) (llvm#170187) This fixes a typo in ScriptedPythonInterface and changes `AbstrackMethodCheckerPayload` to `AbstractMethodCheckerPayload`. Signed-off-by: Med Ismail Bennani <[email protected]> (cherry picked from commit fd8bf3c)
medismailben
added a commit
to medismailben/llvm-project
that referenced
this pull request
Dec 6, 2025
…C) (llvm#170187) This fixes a typo in ScriptedPythonInterface and changes `AbstrackMethodCheckerPayload` to `AbstractMethodCheckerPayload`. Signed-off-by: Med Ismail Bennani <[email protected]> (cherry picked from commit fd8bf3c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a typo in ScriptedPythonInterface and changes
AbstrackMethodCheckerPayloadtoAbstractMethodCheckerPayload.